Extends "spo user ensure" command with support for specifying more options. Closes #6181 #6426
Conversation
|
Thank you @nanddeepn, we'll try to review it ASAP! |
Adam-it
added
the
hacktoberfest-accepted
|
@nanddeepn I added the |
| }); | ||
|
|
||
| await command.action(logger, { options: { verbose: true, webUrl: validWebUrl, entraGroupName: validEntraSecurityGroupName } }); | ||
| assert(loggerLogSpy.calledWith(ensuredSecurityGroupResponse)); |
There was a problem hiding this comment.
Let's check the request body instead of the output of the command.
|
@nanddeepn, did you find some time to look at my comments? |
I have started working on it. Facing some issues with merge conflicts, but will let you know when I update the PR. Thank you. |
|
Hi @milanholemans |
| }); | ||
|
|
||
| await command.action(logger, { options: { verbose: true, webUrl: validWebUrl, loginName: validLoginName } }); | ||
| assert(loggerLogSpy.calledWith(ensuredUserResponse)); |
There was a problem hiding this comment.
Let's check for the request body here as well.
| sinon.stub(entraGroup, 'getGroupById').callsFake(async () => { | ||
| return groupM365Response.value[0]; | ||
| }); |
There was a problem hiding this comment.
| sinon.stub(entraGroup, 'getGroupById').callsFake(async () => { | |
| return groupM365Response.value[0]; | |
| }); | |
| sinon.stub(entraGroup, 'getGroupById').resolves(groupM365Response.value[0]); |
| sinon.stub(entraGroup, 'getGroupByDisplayName').callsFake(async () => { | ||
| return groupSecurityResponse.value[0]; | ||
| }); |
There was a problem hiding this comment.
| sinon.stub(entraGroup, 'getGroupByDisplayName').callsFake(async () => { | |
| return groupSecurityResponse.value[0]; | |
| }); | |
| sinon.stub(entraGroup, 'getGroupByDisplayName').ensures(groupSecurityResponse.value[0]); |
| sinon.stub(entraGroup, 'getGroupByDisplayName').callsFake(async () => { | ||
| return groupM365Response.value[0]; | ||
| }); |
There was a problem hiding this comment.
Let's use .resolves(...)
Extends
spo user ensurecommand with support for specifyingloginName,entraGroupId, andentraGroupNameoptions. Closes #6181